ci(cd_pr): skip argocd_diff for PRs targeting development#19
Merged
Conversation
The testing ArgoCD instance at https://argocd.euc1.t.get-protocol.dev is currently unreachable (HTTP 503). The diff job calls /api/v1/applications on that host, gets HTML back instead of JSON, and fails. This breaks every PR opened against development across every repo using this reusable workflow — message-service, entrails, and others. Skipping the job for development base unblocks those PRs without losing visibility on master/production diffs (production ArgoCD is healthy). When the testing cluster is restored, revert the if condition. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The reusable `argocd_diff` job currently runs on PRs targeting `development`, `master`, and `production`. For the development base, it calls the testing ArgoCD at `https://argocd.euc1.t.get-protocol.dev\` — which is currently down (HTTP 503 from the browser, HTML returned instead of JSON in the action).
This breaks every PR opened against `development` across every repo consuming this reusable workflow:
Example failure: `FetchError: invalid json response body ... reason: Unexpected token '<', "` — the standard signature of an ingress returning an error page in place of API JSON.
Change
Remove `development` from the job's `if:` condition. The job still runs on PRs targeting `master` (staging ArgoCD) and `production` (production ArgoCD, verified healthy via working `deploy-argocd` jobs).
A comment is added in-place explaining why and how to revert when the testing cluster is restored.
What this does NOT change
Test plan
Follow-up (not in scope of this PR)
The testing ArgoCD being down is a separate infrastructure issue worth investigating — owners of `deployments` / `k8seks` / `terraform` would know whether it was decommissioned intentionally or is broken. When restored, revert the if condition per the inline comment.
🤖 Generated with Claude Code